Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zzguang as a maintainer of OpenYurt #1099

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Add zzguang as a maintainer of OpenYurt #1099

merged 1 commit into from
Dec 13, 2022

Conversation

zzguang
Copy link
Member

@zzguang zzguang commented Dec 12, 2022

Signed-off-by: zzguang [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

@openyurt-bot
Copy link
Collaborator

@zzguang: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Signed-off-by: zzguang [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Dec 12, 2022
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #1099 (cf255dd) into master (a16c6d1) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1099      +/-   ##
==========================================
- Coverage   53.11%   53.10%   -0.02%     
==========================================
  Files          95       95              
  Lines       12726    12726              
==========================================
- Hits         6760     6758       -2     
- Misses       5396     5397       +1     
- Partials      570      571       +1
Flag Coverage Δ
unittests 53.10% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/iptables/iptables.go 87.12% <0.00%> (-0.55%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

@zzguang please add some contributions about you in the issue.

@gnunu
Copy link
Member

gnunu commented Dec 12, 2022

agree +1

@zzguang
Copy link
Member Author

zzguang commented Dec 12, 2022

@zzguang please add some contributions about you in the issue.

My major contributions are listed below:

@rambohe-ch
Copy link
Member

@zzguang agree +1

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label Dec 13, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, zzguang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Dec 13, 2022
@openyurt-bot openyurt-bot merged commit ddccd97 into openyurtio:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambohe-ch rambohe-ch rambohe-ch approved these changes

@charleszheng44 charleszheng44 Awaiting requested review from charleszheng44

@huangyuqi huangyuqi Awaiting requested review from huangyuqi

Assignees

@rambohe-ch rambohe-ch

Labels
approved approved lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zzguang @openyurt-bot @rambohe-ch @gnunu